Address ZDI-20-1051 / ZDI-CAN-10436: Prevent deserializing a class. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also guard against some other possibly unwanted deserialisations. It is debatable if this constitutes an actual attack vector before the change. However, the change rules out any such possibility.
|
I think this is fit for master but not for FW_5_2 as-is due to used PHP features. |
|
I agree. The allowed_classes option isn't available until PHP 7.0 so this can't be used in FW_5_2. Also note that this would only be a stop gap for this specific preference while we implement a more complete refactoring/replacing of how we handle allowing this prefs to be set. |
|
I agree. I was working on a more general solution but it needs a little more time. |
ralflang
pushed a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with https://www.zerodayinitiative.com/advisories/ZDI-20-1051/
Also guard against some other possibly unwanted deserialisations. It is debatable if this constitutes an actual attack vector before the change. However, the change rules out any such possibility.
See discussion on the ML https://lists.horde.org/archives/horde/Week-of-Mon-20221010/059302.html
@mrubinsk I have given this some limited functional testing but it might make sense to have a closer look.